You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 09:31:06 UTC

[GitHub] [arrow-rs] martin-g commented on a diff in pull request #1873: Do not print exit code from miri, instead it should be the return value of the script

martin-g commented on code in PR #1873:
URL: https://github.com/apache/arrow-rs/pull/1873#discussion_r896595063


##########
.github/workflows/miri.sh:
##########
@@ -15,4 +15,3 @@ cargo clean
 
 echo "Starting Arrow MIRI run..."
 cargo miri test -p arrow -- --skip csv --skip ipc --skip json

Review Comment:
   You could use something like:
   ```bash
   cargo miri test -p arrow -- --skip csv --skip ipc --skip json
   MIRI_RETURN_CODE=$?
   echo "Miri finished with exit code $MIRI_RETURN_CODE"
   exit $MIRI_RETURN_CODE
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org