You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/30 21:08:04 UTC
[jira] [Commented] (LUCENE-6646) support SortingMergePolicy-free
use of EarlyTerminatingSortingCollector
[ https://issues.apache.org/jira/browse/LUCENE-6646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608882#comment-14608882 ]
ASF GitHub Bot commented on LUCENE-6646:
----------------------------------------
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/175
support SortingMergePolicy-free use of EarlyTerminatingSortingCollector
for https://issues.apache.org/jira/i#browse/LUCENE-6646
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-sort-outline-lucene
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #175
----
commit 5984692c660b32ddec0260e5a096b7b7eea5ea8d
Author: Christine Poerschke <cp...@bloomberg.net>
Date: 2015-06-29T15:02:44Z
LUCENE-????: support SortingMergePolicy-free use of EarlyTerminatingSortingCollector
motivation:
* SOLR-5730 to make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr.
* outline of draft SOLR-5730 changes:
+ SolrIndexWriter constructor calls SolrIndexConfig.toIndexWriterConfig (passing the result to its lucene.IndexWriter super class)
+ SolrIndexConfig.toIndexWriterConfig(SolrCore core) calls SolrIndexConfig.buildMergePolicy
+ SolrIndexConfig.buildMergePolicy(IndexSchema schema) calls the SortingMergePolicy constructor (using the IndexSchema's mergeSortSpec)
+ SolrIndexSearcher.buildAndRunCollectorChain calls the EarlyTerminatingSortingCollector constructor (using the IndexSchema's mergeSortSpec)
summary of changes:
* added static isSorted variant to SortingMergePolicy
* added SortingMergePolicy-free EarlyTerminatingSortingCollector constructor variant
* added SortingMergePolicy-free EarlyTerminatingSortingCollector.canEarlyTerminate variant
* corresponding changes to TestEarlyTerminatingSortingCollector (randomly choose between constructor and canEarlyTerminate variants)
----
> support SortingMergePolicy-free use of EarlyTerminatingSortingCollector
> -----------------------------------------------------------------------
>
> Key: LUCENE-6646
> URL: https://issues.apache.org/jira/browse/LUCENE-6646
> Project: Lucene - Core
> Issue Type: Wish
> Reporter: Christine Poerschke
> Priority: Minor
>
> motivation and summary of proposed changes to follow via github pull request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org