You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/19 07:28:00 UTC
[jira] [Commented] (GEODE-7773) Remove redundant addAll command in
LuceneListIndexCommand
[ https://issues.apache.org/jira/browse/GEODE-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039758#comment-17039758 ]
ASF subversion and git services commented on GEODE-7773:
--------------------------------------------------------
Commit 9ad6417e0d1813d3bc0a9ada32ee9ff501e32485 in geode's branch refs/heads/develop from mkevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9ad6417 ]
GEODE-7773: remove redundant addAll command (#4703)
> Remove redundant addAll command in LuceneListIndexCommand
> ---------------------------------------------------------
>
> Key: GEODE-7773
> URL: https://issues.apache.org/jira/browse/GEODE-7773
> Project: Geode
> Issue Type: Task
> Components: gfsh, lucene
> Reporter: Jason Huynh
> Assignee: Mario Kevo
> Priority: Major
> Labels: beginner, newb, starter
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The collection named uniqResults is instantiated and addAll is invoked with a collection. Instead we can optimize and instantiate the uniqResults with the collection as a parameter.
> [https://github.com/apache/geode/blob/d5a191ec02bcff8ebfd090484b50a63ec9352f8e/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneListIndexCommand.java#L68]
>
> The change would look similar to:
> {code:java}
> LinkedHashSet<LuceneIndexDetails> uniqResults = new LinkedHashSet<>(sortedResults);{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)