You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:34:20 UTC
[GitHub] [flink] echauchot opened a new pull request, #21636: [FLINK-30113] Implement operator state compression for broadcast and regular states
echauchot opened a new pull request, #21636:
URL: https://github.com/apache/flink/pull/21636
…
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1450215921
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1385458367
> > Ok, I'll write the FLIP and ping you on it for review, then when we agree on the architecture, I'll write the code and commit on this PR.
>
> @dawidwys I don't have the rights to add a FLIP to Flink confluence space. Can you give me the rights ?
@dawidwys [here](https://cwiki.apache.org/confluence/display/FLINK/FLIP-289+Operator+state+compression) is the flip, cn you please review it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1451865056
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
dawidwys commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1383838719
> No, see DefaultOperatorStateBackendBuilder I call AbstractStateBackend.getCompressionDecorator that reads execution.checkpointing.snapshot-compression conf parameter.
Ah, sorry missed that :(
> Ok, adding the boolean will require to change the snapshot format indeed. This is why I have not added this boolean to avoid the format change. But, indeed, if a snapshot was compressed and the user then disables compression he could not read the previous compressed snapshot with my code. What about simply adding a compression boolean to operator state meta ? As a backward incompatible change, it requires a FLIP even if simple change, right ?
Yes, I do think it requires a FLIP as it is a substantial change, but I believe this change is unavoidable if we want to add operator state compression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1458170574
> > LGTM, let's wait until e2e tests are fixed though before we merge it.
>
> These E2E tests have been fixed for some time already, you probably need to rebase :) See https://issues.apache.org/jira/browse/FLINK-30972
Thanks @MartijnVisser, I missed this ticket. I just rebased. Let's wait for the green lights.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1457760168
> What you did for versioning looks sane. I think the problem is with line
>
> https://github.com/apache/flink/blob/a4a11a389609deb5d1de139115cedc35b675b366/flink-runtime/src/main/java/org/apache/flink/runtime/state/metainfo/StateMetaInfoSnapshotReadersWriters.java#L68
>
> which has not been implemented in a future proof way. The intent there was to throw an exception for `readVersion < 6`, not less than `CURRENT_STATE_META_INFO_SNAPSHOT_VERSION`. If we change the condition to `readVersion < 6` it should work.
Hi @dawidwys, thanks for the prompt answer. I suspected something not future proof, thanks for the confirmation. It is now fixed. Tests pass but the CI fails in preparation of the E2E tests (since some days) with a http 404 error.
PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1376983860
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d17d887db57a3c9e22ebe968951c7d26abd25e21",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d17d887db57a3c9e22ebe968951c7d26abd25e21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d17d887db57a3c9e22ebe968951c7d26abd25e21 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1458143750
> LGTM, let's wait until e2e tests are fixed though before we merge it.
These E2E tests have been fixed for some time already, you probably need to rebase :) See https://issues.apache.org/jira/browse/FLINK-30972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1384047261
> > No, see DefaultOperatorStateBackendBuilder I call AbstractStateBackend.getCompressionDecorator that reads execution.checkpointing.snapshot-compression conf parameter.
>
> Ah, sorry missed that :( That part looks good then.
>
> > Ok, adding the boolean will require to change the snapshot format indeed. This is why I have not added this boolean to avoid the format change. But, indeed, if a snapshot was compressed and the user then disables compression he could not read the previous compressed snapshot with my code. What about simply adding a compression boolean to operator state meta ? As a backward incompatible change, it requires a FLIP even if simple change, right ?
>
> Yes, I do think it requires a FLIP as it is a substantial change, but I believe this change is unavoidable if we want to add operator state compression.
Ok, I'll write the FLIP and ping you on it for review, then when we agree on the architecture, I'll write the code and commit on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1378753852
@dawidwys Could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1456219906
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1456287361
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1457876791
Thanks for the review Dawid !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
dawidwys commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1377522284
Thanks for the PR. I'll review it over the next few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1406565681
The vote on the FLIP has passed, but I'm going on vacation tonight for a week. I'll update this PR to reflect the FLIP when I get back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1455911732
What you did for versioning looks sane. I think the problem is with line https://github.com/apache/flink/blob/a4a11a389609deb5d1de139115cedc35b675b366/flink-runtime/src/main/java/org/apache/flink/runtime/state/metainfo/StateMetaInfoSnapshotReadersWriters.java#L68 which has not been implemented in a future proof way. The intent there was to throw an exception for `readVersion < 6`, not less than `CURRENT_STATE_META_INFO_SNAPSHOT_VERSION`. If we change the condition to `readVersion < 6` it should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1452063429
Hi @dawidwys, my code is failing with versioning. I incremented the proxy version (as the metadata serde code has changed) and the snapshot version (as I added a boolean for compression). Can you explain how the proxy/snapshot versioning works because I see nothing in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1458171760
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1383753431
> Hey @echauchot Thanks for working on the issue.
>
> Correct me if I am wrong, but in the current state you always apply the compression for the operator state.
>
No, see `DefaultOperatorStateBackendBuilder` I call `AbstractStateBackend.getCompressionDecorator` that reads `execution.checkpointing.snapshot-compression` conf parameter.
> First of all, imo, this needs to be configurable. I'd say it can be done with the same flag as for the keyed state backend (`execution.checkpointing.snapshot-compression`)
See above, I've found we could reuse `execution.checkpointing.snapshot-compression` conf parameter. Tell me if you want it to be a different conf parameter.
> Moreover, right now it causes previously written checkpoints to be unreadable. (have you tried restoring from an old checkpoint? If not, could you add such a test?) as it always assumes the stream is compressed.
> The info if the state is compressed or not needs to be persisted somewhere. I don't have a good idea for that now. In the keyed state case it is done via `KeyedBackendSerializationProxy#read/write`.
Well, if the user disables compression to read uncompressed snapshots, then it works.
Though, I have not tested to restore old snapshots. I have just tested the state write/read roundtrip via existing tests. I'll add such a test
Yes I saw that with key state a boolean is written first when the state is written. I can do similar thing for operator state.
>
> Now I realise this might require changes to the checkpoint format, unless we figure out a smart place to put it, so we might need to create a small FLIP for that.
Ok, adding the boolean will require to change the snapshot format indeed. This is why I have not added this boolean to avoid the format change. But, indeed, if a snapshot was compressed and the user then disables compression he could not read the previous compressed snapshot with my code. What about simply adding a compression boolean to operator state meta ? Need a FLIP for this change ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1449683305
@dawidwys sorry for the delay, I had to finish [this other PR](https://github.com/apache/flink-connector-cassandra/pull/3) after my vacations. Resuming the work on this PR ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1459954014
@dawidwys thanks for reviewing/merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #21636:
URL: https://github.com/apache/flink/pull/21636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
echauchot commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1384231994
> Ok, I'll write the FLIP and ping you on it for review, then when we agree on the architecture, I'll write the code and commit on this PR.
@dawidwys I don't have the rights to add a FLIP to Flink confluence space. Can you give me the rights ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1385023159
> Can you give me the rights ?
@echauchot You should have the rights now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #21636: [FLINK-30113] Implement state compression for broadcast and regular operator states
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on PR #21636:
URL: https://github.com/apache/flink/pull/21636#issuecomment-1406568029
Absolutely @echauchot ! Thanks for the work so far!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org