You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/27 09:50:19 UTC
[GitHub] [flink] JingsongLi opened a new pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
JingsongLi opened a new pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704
## What is the purpose of the change
When use DATE/TIME/TIMESTAMP partition columns, planner will not do partition pruning, that lead to read all partitions.
## Brief change log
- Fix comparison of timestamp with local time zone
- Fix prune partition on DATE/TIME/TIMESTAMP columns
- Fix listPartitions in HiveCatalog & Add time prune partition tests
## Verifying this change
- HiveTableSourceTest.testPartitionFilterDateTimestamp
- PartitionPruneTest.testTimePrunePartitions
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142727399 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142727399) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142727399 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142727399) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142727399 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4027 TriggerType:PUSH TriggerID:cf5d3c1bafdb05c55e91a71ec662ce2bee513177
Hash:cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142831069 TriggerType:PUSH TriggerID:cf5d3c1bafdb05c55e91a71ec662ce2bee513177
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142727399) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007)
* cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142831069) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569235348
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit de210eacfb754ef4d169bbfb50877d3e03e8c792 (Fri Dec 27 09:53:26 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#discussion_r362152117
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -783,6 +783,10 @@ class TemporalTypesTest extends ExpressionTestBase {
testSqlApi(timestampTz("2018-03-14 19:01:02.123"), "2018-03-14 19:01:02.123")
testSqlApi(timestampTz("2018-03-14 19:00:00.010"), "2018-03-14 19:00:00.01")
+ testSqlApi(
+ timestampTz("2018-03-14 19:00:00.010") + " > " + timestampTz("2018-03-14 19:00:00.012"),
Review comment:
It seems that this test doesn't reproduce the bug. Could use replace one of the constants to a field reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#discussion_r362168806
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -953,7 +954,7 @@ private static CatalogPartitionSpec createPartitionSpec(String hivePartitionName
Map<String, String> spec = new HashMap<>(partKeyVals.length);
for (String keyVal : partKeyVals) {
String[] kv = keyVal.split("=");
- spec.put(kv[0], kv[1]);
+ spec.put(unescapePathName(kv[0]), unescapePathName(kv[1]));
Review comment:
Not related to this PR, but maybe we need more tests for this, e.g. string partition columns with special characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#discussion_r362147386
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractorTest.scala
##########
@@ -820,8 +820,8 @@ class RexNodeExtractorTest extends RexNodeTestBase {
rexBuilder,
Array("date")
)
- assertTrue(partitionPredicate1.isAlwaysTrue)
- assertEquals(c3, nonPartitionPredicate1)
+ assertEquals(c2, partitionPredicate1)
+ assertEquals(c1, nonPartitionPredicate1)
// date is not supported
Review comment:
Remove this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142727399 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cf5d3c1bafdb05c55e91a71ec662ce2bee513177
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142727399) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007)
* cf5d3c1bafdb05c55e91a71ec662ce2bee513177 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569579092
CC:
@wuchong for blink part.
@lirui-apache for hive part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-570128751
Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#discussion_r362359718
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -953,7 +954,7 @@ private static CatalogPartitionSpec createPartitionSpec(String hivePartitionName
Map<String, String> spec = new HashMap<>(partKeyVals.length);
for (String keyVal : partKeyVals) {
String[] kv = keyVal.split("=");
- spec.put(kv[0], kv[1]);
+ spec.put(unescapePathName(kv[0]), unescapePathName(kv[1]));
Review comment:
I added test in `HiveTableSourceTest.testPartitionFilter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10704:
[FLINK-15411][table-planner-blink] Fix prune partition on
DATE/TIME/TIMESTAMP columns
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10704: [FLINK-15411][table-planner-blink] Fix prune partition on DATE/TIME/TIMESTAMP columns
URL: https://github.com/apache/flink/pull/10704#issuecomment-569239989
<!--
Meta data
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142444279 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:de210eacfb754ef4d169bbfb50877d3e03e8c792 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954 TriggerType:PUSH TriggerID:de210eacfb754ef4d169bbfb50877d3e03e8c792
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:749a0addc128db847dcc13b4494148474b50bee2 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142609801 TriggerType:PUSH TriggerID:749a0addc128db847dcc13b4494148474b50bee2
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142720734 TriggerType:PUSH TriggerID:30cee33e9aa2601b3266871a7f30dda41f8dc0a4
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:1510d279b5317a3d968dd4245b90975c1269d30f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142727399 TriggerType:PUSH TriggerID:1510d279b5317a3d968dd4245b90975c1269d30f
Hash:cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4027 TriggerType:PUSH TriggerID:cf5d3c1bafdb05c55e91a71ec662ce2bee513177
Hash:cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831069 TriggerType:PUSH TriggerID:cf5d3c1bafdb05c55e91a71ec662ce2bee513177
-->
## CI report:
* de210eacfb754ef4d169bbfb50877d3e03e8c792 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142444279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3954)
* 749a0addc128db847dcc13b4494148474b50bee2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142609801) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3970)
* 30cee33e9aa2601b3266871a7f30dda41f8dc0a4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142720734) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4000)
* 1510d279b5317a3d968dd4245b90975c1269d30f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142727399) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4007)
* cf5d3c1bafdb05c55e91a71ec662ce2bee513177 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142831069) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4027)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services