[GitHub] [incubator-gobblin] zxcware opened a new pull request #2632: [GOBBLIN-769] Support string record timestamp in TimeBasedAvroWriterPartitioner

[GitBox <gi...@apache.org>]

zxcware opened a new pull request #2632: [GOBBLIN-769] Support string record timestamp in TimeBasedAvroWriterPartitioner
URL: https://github.com/apache/incubator-gobblin/pull/2632
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
       - https://issues.apache.org/jira/browse/GOBBLIN-769
   
   
   ### Description
   - [x] Here are some details about my PR:
   - Currently, if a record timestamp is a string, `TimeBasedAvroWriterPartitioner` will not be able to recognize it and will use current time. This change will try to convert a string to Long before using current time
   
   ### Tests
   - [x] My PR adds the following unit tests:
   - `TimeBasedAvroWriterPartitioner.testGetRecordTimestamp` covers various cases for reading string record timestamp
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services