[GitHub] villebro commented on a change in pull request #5294: Scheduled email reports for Slices / Dashboards

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #5294: Scheduled email reports for Slices / Dashboards
URL: https://github.com/apache/incubator-superset/pull/5294#discussion_r207703825
 
 

 ##########
 File path: setup.py
 ##########
 @@ -96,6 +96,8 @@ def get_git_sha():
         'thrift-sasl>=0.2.1',
         'unicodecsv',
         'unidecode>=0.04.21',
+        'croniter==0.3.24',
+        'selenium==3.12.0',
     ],
 
 Review comment:
   Nit: is there a reason why these are pegged to these specific versions, and not `<=` or `>=`? The version of `croniter` current, but selenium has had two minor releases since, with the latest yesterday. If there are no known compatibility issues with future versions, perhaps these should be left unpegged in `setup.py`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org