[GitHub] [spark] huaxingao commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #27978: [SPARK-31127][ML] Implement abstract Selector
URL: https://github.com/apache/spark/pull/27978#discussion_r396115293
 
 

 ##########
 File path: project/MimaExcludes.scala
 ##########
 @@ -38,7 +38,11 @@ object MimaExcludes {
   lazy val v31excludes = v30excludes ++ Seq(
     // [SPARK-31077] Remove ChiSqSelector dependency on mllib.ChiSqSelectorModel
     // private constructor
-    ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel.this")
+    ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel.this"),
+    // [SPARK-31127] Implement abstract Selector
+    ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ml.feature.ChiSqSelectorModel"),
 
 Review comment:
   This is for 3.1 only.
   
   The first two MiMa errors are because of type hierarchy change. 
   ```
   [error]  * the type hierarchy of class org.apache.spark.ml.feature.ChiSqSelectorModel is different in current version. Missing types {org.apache.spark.ml.feature.ChiSqSelectorParams}
   ```
   The 3rd MiMa error is due to return type change.
   ```
   [error]  * method fit(org.apache.spark.sql.Dataset)org.apache.spark.ml.feature.ChiSqSelectorModel in class org.apache.spark.ml.feature.ChiSqSelector has a different result type in current version, where it is org.apache.spark.ml.feature.SelectorModel rather than org.apache.spark.ml.feature.ChiSqSelectorModel
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org