You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "John Plevyak (JIRA)" <ji...@apache.org> on 2009/12/08 16:42:18 UTC

[jira] Created: (TS-75) dependencies not always working

dependencies not always working
-------------------------------

                 Key: TS-75
                 URL: https://issues.apache.org/jira/browse/TS-75
             Project: Traffic Server
          Issue Type: Bug
          Components: Build
            Reporter: John Plevyak
         Attachments: ts-memcpy-jp-v1.patch

When applying a patch, the dependency system did not correctly rebuild Prefetch.o
as well as some other files for changes to I_IOBuffer.h

Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-75) dependencies not always working

Posted by "Andrew Hsu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788226#action_12788226 ] 

Andrew Hsu commented on TS-75:
------------------------------

>From IRC chat conversation:

andrewhsu: hmm...i notice that files like AbstractBuffer.cc is specified as a SOURCES for libTrafficServerStandalone and traffic_server.  but ICP.cc is only specified as a SOURCES for traffic_server.  it also looks like .Po files are created for all .cc files upon the first execution of `make`.  it may be that ICP.Po is created but never used by the build system (because it already has traffic_server-ICP.Po).  but for some reason files like AbstractBuffer.Po is created and then used in the final 'Makefile' that is generated.

I believe the fix is to not have the logstat, logcat, etc files LDADD the .o files directly, but instead have a static library shared between the linking of various binaries so the deps link up properly.

For now, workaround is to do `make clean` if you know you are changing a file that is not linked up properly with deps.

I'll take ownership of this jira.

> dependencies not always working
> -------------------------------
>
>                 Key: TS-75
>                 URL: https://issues.apache.org/jira/browse/TS-75
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: John Plevyak
>         Attachments: ts-memcpy-jp-v1.patch
>
>
> When applying a patch, the dependency system did not correctly rebuild Prefetch.o
> as well as some other files for changes to I_IOBuffer.h
> Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-75) dependencies not always working

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839059#action_12839059 ] 

John Plevyak commented on TS-75:
--------------------------------

I fixed part of this by making the flags identical for all the targets so that there would only be one set of .Po files.

> dependencies not always working
> -------------------------------
>
>                 Key: TS-75
>                 URL: https://issues.apache.org/jira/browse/TS-75
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: John Plevyak
>            Assignee: Andrew Hsu
>         Attachments: ts-memcpy-jp-v1.patch
>
>
> When applying a patch, the dependency system did not correctly rebuild Prefetch.o
> as well as some other files for changes to I_IOBuffer.h
> Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TS-75) dependencies not always working

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Plevyak updated TS-75:
---------------------------

    Attachment: ts-memcpy-jp-v1.patch

> dependencies not always working
> -------------------------------
>
>                 Key: TS-75
>                 URL: https://issues.apache.org/jira/browse/TS-75
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: John Plevyak
>         Attachments: ts-memcpy-jp-v1.patch
>
>
> When applying a patch, the dependency system did not correctly rebuild Prefetch.o
> as well as some other files for changes to I_IOBuffer.h
> Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TS-75) dependencies not always working

Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828729#action_12828729 ] 

John Plevyak commented on TS-75:
--------------------------------

Another interesting thing I noticed is that if one does a 'make'
in the proxy directory, it will rebuild the executable but not
rebuild the other libraries (not under proxy).  This is a bit
confusing.  I would think that either it would not build an executable
or it would rebuild the libraries as well.

> dependencies not always working
> -------------------------------
>
>                 Key: TS-75
>                 URL: https://issues.apache.org/jira/browse/TS-75
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: John Plevyak
>            Assignee: Andrew Hsu
>         Attachments: ts-memcpy-jp-v1.patch
>
>
> When applying a patch, the dependency system did not correctly rebuild Prefetch.o
> as well as some other files for changes to I_IOBuffer.h
> Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (TS-75) dependencies not always working

Posted by "Andrew Hsu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Hsu reassigned TS-75:
----------------------------

    Assignee: Andrew Hsu

> dependencies not always working
> -------------------------------
>
>                 Key: TS-75
>                 URL: https://issues.apache.org/jira/browse/TS-75
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: John Plevyak
>            Assignee: Andrew Hsu
>         Attachments: ts-memcpy-jp-v1.patch
>
>
> When applying a patch, the dependency system did not correctly rebuild Prefetch.o
> as well as some other files for changes to I_IOBuffer.h
> Back out the attached patch and then reapply without doing a 'make clean' to see the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.