[jira] Commented: (DERBY-1726) Make i18n/LocalizedDisplay.sql and i18n/LocalizedConnectionAttribute.sql behave equally on different platforms

["Myrna van Lunteren (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617988#action_12617988 ] 

Myrna van Lunteren commented on DERBY-1726:
-------------------------------------------

I looked at this for a while, and there are remnants of disappeard(removed) cloudscape technology here - the LocalizedDisplay test sets ij.unicodeEscape=on, and there is code in LocalizedResource that handles setting and getting this property, but I don't see that the property is checked/used anywhere (except in the LocalizedResource.toString()).

The question is, should we try to reinvent this functionality? If so, I'll log an improvement against ij, but I've no plans to do this myself right now.

In the mean time, we should remove the remnants of that code. For instance, derbyall includes the test UnicodeEscape_JP.sql. At one time this test may have made sense if it would switch to UnicodeEscape mode, but as this functionality has been removed, running the UnicodeEscape_JP.sql test is pointless. Similarly, the setting of ij.unicodeEscape=on in LocalizedDisplay_app.properties is pointless. I also think JapanCodeConversion deserves a closer look. 

To resolve the current test issue, I am going to try to do a native2ascii reverse on LocalizedDisplay.sql.

> Make i18n/LocalizedDisplay.sql and i18n/LocalizedConnectionAttribute.sql behave equally on different platforms
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1726
>                 URL: https://issues.apache.org/jira/browse/DERBY-1726
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.2.1.6
>            Reporter: Knut Anders Hatlen
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-1726_1.diff, DERBY-1726_2.diff, DERBY-1726_3.diff, DERBY-1726_3.stat, DERBY-1726_4.diff, DERBY-1726_5.diff, DERBY-1726_6.diff, props.java
>
>
> Myrna van Lunteren commented on DERBY-244:
> The one remark I have is that I still cannot get the LocalizedDisplay.sql and LocalizedConnectionAttribute.sql test from the i18n directory to behave the same under windows and Linux (with sun jdk 1.4.2.).
> For windows, I had to update the masters for these tests, but running them on Linux still failed for me.
> With jdk131, ibm131 and ibm142 the LocalizedDisplay.sql test hung, and LocalizedConnectionAttribute exits with a MalformedInputException.
> It would be nice if we could figure out a way to add these tests to the suites...
> --- stack of LocalizedConnectionAttribute on Linux ---
> Exception in thread "main" sun.io.MalformedInputException
>         at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java(Compiled Code))
>         at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:287)
>         at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:337)
>         at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:223)
>         at java.io.InputStreamReader.read(InputStreamReader.java:208)
>         at java.io.BufferedReader.fill(BufferedReader.java:153)
>         at java.io.BufferedReader.readLine(BufferedReader.java:316)
>         at java.io.BufferedReader.readLine(BufferedReader.java:379)
>         at org.apache.derbyTesting.functionTests.harness.RunTest.setDirectories(RunTest.java:729)
>         at org.apache.derbyTesting.functionTests.harness.RunTest.main(RunTest.java:262)
> ---------------------------------------------------------------------------- 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.