You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 13:44:44 UTC
[GitHub] [incubator-tvm] akosik-anyvision opened a new issue #5728: Mismatched new / delete [] in Relay VM
akosik-anyvision opened a new issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728
There seem to be mismatched new / delete[] statements in the following lines:
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L264
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L267
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L270
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L273
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L276
https://github.com/apache/incubator-tvm/blob/a64208910b22b60da5eb312d3a63cffb6e11f747/src/runtime/vm/vm.cc#L279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639156952
ah, I see. We should have used `delete[]`. You are welcome to send a PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics closed issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
zhiics closed issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] akosik-anyvision commented on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
akosik-anyvision commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639144034
Sorry, the title is backwards. The issue is that `new[]` is used to allocate objects that are deleted with `delete`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639133231
cc @jroesch @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] akosik-anyvision edited a comment on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
akosik-anyvision edited a comment on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639488053
> ah, I see. We should have used delete[]. You are welcome to send a PR. Thanks.
Thanks for confirming. I would've done that directly, but I was waiting on approval from my company.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639138972
They are allocated when the instruction is constructed and deleted when it is deconstructed
https://github.com/apache/incubator-tvm/blob/34c95a89eae13043aa3a269ad7d27d28837ffb56/src/runtime/vm/vm.cc#L100-L103
https://github.com/apache/incubator-tvm/blob/34c95a89eae13043aa3a269ad7d27d28837ffb56/src/runtime/vm/vm.cc#L66-L71
I don't think there is a mismatch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] akosik-anyvision commented on issue #5728: Mismatched new / delete [ ] in Relay VM
Posted by GitBox <gi...@apache.org>.
akosik-anyvision commented on issue #5728:
URL: https://github.com/apache/incubator-tvm/issues/5728#issuecomment-639488053
> ah, I see. We should have used delete[]. You are welcome to send a PR. Thanks.
Thanks for confirming. I would've done that directly, but I was waiting on approval from my company.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org