You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/07/25 03:23:08 UTC

[GitHub] [carbondata] xubo245 commented on a change in pull request #3834: [CARBONDATA-3865] Implementation of delete/update feature in carbondata SDK.

xubo245 commented on a change in pull request #3834:
URL: https://github.com/apache/carbondata/pull/3834#discussion_r460357773



##########
File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
##########
@@ -189,16 +196,14 @@ public CarbonTable getOrCreateCarbonTable(Configuration configuration) throws IO
         info.setBlockSize(carbonFile.getLength());
         info.setVersionNumber(split.getVersion().number());
         info.setUseMinMaxForPruning(false);
+        if(allDeleteDeltaFiles.size() != 0) {

Review comment:
       Suggestion： CollectionUtils.isNotEmpty(allDeleteDeltaFiles)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org