You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:59:25 UTC

[GitHub] [pulsar] merlimat opened a new pull request #8771: [C++] Fixed flaky test: AuthPluginTest.testTlsDetectHttpsWithHostNameValidation

merlimat opened a new pull request #8771:
URL: https://github.com/apache/pulsar/pull/8771


   ### Motivation
   
   The test is wrong because the assertion is never checked, since we're not throwing exception when the hostname validation fails. It is also causing a segfault, because the promise object is already destroyed when the callback is triggered in background.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #8771: [C++] Fixed flaky test: AuthPluginTest.testTlsDetectHttpsWithHostNameValidation

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #8771:
URL: https://github.com/apache/pulsar/pull/8771


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #8771: [C++] Fixed flaky test: AuthPluginTest.testTlsDetectHttpsWithHostNameValidation

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8771:
URL: https://github.com/apache/pulsar/pull/8771#issuecomment-736917308


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org