You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/03/10 20:18:41 UTC
[GitHub] metamodel pull request: Javadoc fixes
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/91
Javadoc fixes
This PR fixes a bunch of errors in the javadoc comments of MetaModel. While running `mvn javadoc:javadoc` on a Java 8 runtime, then these bring build failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel javadoc-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 8ea5ef52659abee313957fa7164c1b3f55a31674
Author: Ankit Kumar <ak...@gmail.com>
Date: 2016-03-09T17:55:06Z
METAMODEL-239: Fixed
Fixes #90
commit 60a4c56e1043b8981f90b9b4d28c7772c7d370a9
Author: Kasper Sørensen <i....@gmail.com>
Date: 2016-03-10T19:16:27Z
Fixes 'mvn javadoc:javadoc' errors with Java 8 javadoc linter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/91#discussion_r55796600
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java ---
@@ -69,11 +69,11 @@ public String rewriteQuery(Query query) {
final Integer firstRow = query.getFirstRow();
final Integer maxRows = query.getMaxRows();
- if (maxRows == null && firstRow == null) {
+ if (maxRows == null && (firstRow == null || firstRow.intValue() == 1)) {
--- End diff --
Shouldn't this be included in another PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/91#issuecomment-195369705
Hmm seems something is odd with the github mirror ... The commit has been made on our primary git repo, but not synced to master on github. See for yourself: https://git-wip-us.apache.org/repos/asf?p=metamodel.git
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/91#discussion_r55819299
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java ---
@@ -69,11 +69,11 @@ public String rewriteQuery(Query query) {
final Integer firstRow = query.getFirstRow();
final Integer maxRows = query.getMaxRows();
- if (maxRows == null && firstRow == null) {
+ if (maxRows == null && (firstRow == null || firstRow.intValue() == 1)) {
--- End diff --
Yes, but something went wrong - somehow @ankit2711's commit went into my PR ... Don't know why... at least it's not "my" change and wasn't my intention ... sorry, will repost I guess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/91#issuecomment-197664398
Now it should be updated, thanks to INFRA. Can you give it an updated look @albertostratio ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Javadoc fixes
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/91#issuecomment-197735498
LGTM @kaspersorensen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---