[GitHub] [arrow-datafusion] alamb commented on pull request #6158: Port test in select.rs to sqllogic

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #6158:
URL: https://github.com/apache/arrow-datafusion/pull/6158#issuecomment-1530147582

   > K-way sort preserving merge because there is a clever bit of the code that uses an array representation of a binary tree (to implement losers tree).
   
   
   
   Yes, I agree this is quite a nice piece of code that is non trivial. I think the parts of DataFusion that are the most performance critical are also the parts that are the hardest to understand. It would be great to improve the understandability. 
   
   @aprimadi  I wonder if you might be willing to take a shot at adding some comments (perhaps copy/paste/modify your comments in https://github.com/apache/arrow-datafusion/pull/6158#issuecomment-1529252222) to help other future readers
   
   Also, I will try and be better about triaging tickets as they come in and marking the relevant ones as "good first issues" -- https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
   
   It is a little lacking now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org