You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by co...@apache.org on 2016/08/07 02:29:57 UTC
zeppelin git commit: [BugFix] Show checkbox for "Connect to existing
process" on interpreter menu.
Repository: zeppelin
Updated Branches:
refs/heads/master b00792495 -> 55695c9c3
[BugFix] Show checkbox for "Connect to existing process" on interpreter menu.
### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" on interpreter menu.
### What type of PR is it?
Bug Fix
### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing process" exists.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: astroshim <hs...@nflabs.com>
Closes #1229 from astroshim/bugfix/showCheckbox and squashes the following commits:
4b3673a [astroshim] add css to interpreter-create page
17fb0d7 [astroshim] change size to px
47ce719 [astroshim] remove height style on the checkbox
bbc3283 [astroshim] show checkbox on interpreter menu.
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/55695c9c
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/55695c9c
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/55695c9c
Branch: refs/heads/master
Commit: 55695c9c31d4b2b9978cd27a19a64c95f682d637
Parents: b007924
Author: astroshim <hs...@nflabs.com>
Authored: Sat Aug 6 22:10:51 2016 +0900
Committer: Damien CORNEAU <co...@gmail.com>
Committed: Sun Aug 7 11:29:47 2016 +0900
----------------------------------------------------------------------
.../app/interpreter/interpreter-create/interpreter-create.html | 4 ++--
zeppelin-web/src/app/interpreter/interpreter.html | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/55695c9c/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
index 599248b..ea5d98f 100644
--- a/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
+++ b/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html
@@ -72,8 +72,8 @@ limitations under the License.
<div class="col-md-12" style="padding-left:0px">
<div class="checkbox">
- <span class="input-group">
- <label><input type="checkbox" style="width:0%;height:0%" ng-model="newInterpreterSetting.option.isExistingProcess"/> Connect to existing process </label>
+ <span class="input-group" style="line-height:30px;">
+ <label><input type="checkbox" style="width:20px" ng-model="newInterpreterSetting.option.isExistingProcess"/> Connect to existing process </label>
</span>
</div>
</div>
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/55695c9c/zeppelin-web/src/app/interpreter/interpreter.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.html b/zeppelin-web/src/app/interpreter/interpreter.html
index 3c25246..fd88204 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.html
+++ b/zeppelin-web/src/app/interpreter/interpreter.html
@@ -173,8 +173,8 @@ limitations under the License.
<br />
<div class="col-md-12">
<div class="checkbox">
- <span class="input-group">
- <label><input type="checkbox" style="width:0%;height:0%" id="isExistingProcess" ng-model="setting.option.isExistingProcess" ng-disabled="!valueform.$visible"/>
+ <span class="input-group" style="line-height:30px;">
+ <label><input type="checkbox" style="width:20px" id="isExistingProcess" ng-model="setting.option.isExistingProcess" ng-disabled="!valueform.$visible"/>
Connect to existing process </label>
</span>
</div>