[GitHub] Hellojungle commented on a change in pull request #582: Update asynchronous send thread pool from callback executor to an exclusive one.

[GitBox <gi...@apache.org>]

Hellojungle commented on a change in pull request #582: Update asynchronous send thread pool from callback executor to an exclusive one.
URL: https://github.com/apache/rocketmq/pull/582#discussion_r240069155
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
 ##########
 @@ -101,13 +103,33 @@
 
     private MQFaultStrategy mqFaultStrategy = new MQFaultStrategy();
 
+    private final BlockingQueue<Runnable> asyncSenderThreadPoolQueue;
+    private final ExecutorService defaultAsyncSenderExecutor;
+    private ExecutorService asyncSenderExecutor;
+
     public DefaultMQProducerImpl(final DefaultMQProducer defaultMQProducer) {
         this(defaultMQProducer, null);
     }
 
     public DefaultMQProducerImpl(final DefaultMQProducer defaultMQProducer, RPCHook rpcHook) {
         this.defaultMQProducer = defaultMQProducer;
         this.rpcHook = rpcHook;
+
+        this.asyncSenderThreadPoolQueue = new LinkedBlockingQueue<Runnable>(50000);
 
 Review comment:
   What is the consideration of setting 50000?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services