You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/06 07:24:27 UTC
[GitHub] [airflow] malthe opened a new pull request #16282: Fix formatting
malthe opened a new pull request #16282:
URL: https://github.com/apache/airflow/pull/16282
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
malthe commented on pull request #16282:
URL: https://github.com/apache/airflow/pull/16282#issuecomment-855419645
I think the story was that an upgrade to the automated formatted changed
how this syntax ought to be represented. I think a better fix then is to
remove the trailing comma altogether.
søn. 6. jun. 2021 kl. 17.16 skrev Tomek Urbaszek ***@***.***>:
> Wasn't this format used because of #16265
> <https://github.com/apache/airflow/pull/16265> ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/16282#issuecomment-855415200>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAGOJPPEDIMYE5VG7LHQ73TROGONANCNFSM46FSU5VQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #16282:
URL: https://github.com/apache/airflow/pull/16282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #16282:
URL: https://github.com/apache/airflow/pull/16282#issuecomment-855720315
Close as won't fix. If black is happy with it then so are we.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
malthe commented on pull request #16282:
URL: https://github.com/apache/airflow/pull/16282#issuecomment-855767834
@ashb until the day where black is not happy because a trailing slash in function arguments is just weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #16282:
URL: https://github.com/apache/airflow/pull/16282#issuecomment-855415200
Wasn't this format used because of #16265 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on pull request #16282: Fix formatting
Posted by GitBox <gi...@apache.org>.
malthe commented on pull request #16282:
URL: https://github.com/apache/airflow/pull/16282#issuecomment-855382576
The trailing comma is weird, it means the auto formatted form must be
multiline.
søn. 6. jun. 2021 kl. 11.43 skrev Xiaodong DENG ***@***.***>:
> *@XD-DENG* commented on this pull request.
>
> May you clarify why is this an issue?
>
> Both formats are fine, aren't they?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/16282#pullrequestreview-676846799>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAGOJJR3TAVDW3I332YCJLTRM7K3ANCNFSM46FSU5VQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org