You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/04/16 23:54:05 UTC
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/5543
[SPARK-6966][SQL] Use correct ClassLoader for JDBC Driver
Otherwise we cannot add jars with drivers after the fact.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark jdbcClassloader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5543.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5543
----
commit 73d0614f29ccd82e20f246475d2a5cc12c0c236e
Author: Michael Armbrust <mi...@databricks.com>
Date: 2015-04-16T21:52:04Z
[SPARK-6966][SQL] Use correct ClassLoader for JDBC Driver
commit d9930f3c43d31ede1b5c62a00521d47553d0691c
Author: Michael Armbrust <mi...@databricks.com>
Date: 2015-04-16T21:53:39Z
fix imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5543#issuecomment-93849069
[Test build #30438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30438/consoleFull) for PR 5543 at commit [`d9930f3`](https://github.com/apache/spark/commit/d9930f3c43d31ede1b5c62a00521d47553d0691c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5543#issuecomment-93862506
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30438/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5543#issuecomment-93862954
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6966][SQL] Use correct ClassLoader for ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5543#issuecomment-93862498
[Test build #30438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30438/consoleFull) for PR 5543 at commit [`d9930f3`](https://github.com/apache/spark/commit/d9930f3c43d31ede1b5c62a00521d47553d0691c).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org