You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/12/27 21:03:56 UTC

Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Bugs: MESOS-756
    https://issues.apache.org/jira/browse/MESOS-756


Repository: mesos-git


Description
-------

Updated the release script (part 3 per MESOS-756).


Diffs
-----

  support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 

Diff: https://reviews.apache.org/r/16487/diff/


Testing
-------

Tested locally with a dry run.


Thanks,

Vinod Kone


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Vinod Kone <vi...@gmail.com>.

> On Jan. 10, 2014, 8:11 p.m., Ben Mahler wrote:
> > support/release.sh, line 37
> > <https://reviews.apache.org/r/16487/diff/2/?file=403913#file403913line37>
> >
> >     s/Let's download/Downloading/ ? To be consistent with the rest of the script output. (Releasing mesos-....).

done


> On Jan. 10, 2014, 8:11 p.m., Ben Mahler wrote:
> > support/release.sh, line 44
> > <https://reviews.apache.org/r/16487/diff/2/?file=403913#file403913line44>
> >
> >     Checking out the svn ...

done


> On Jan. 10, 2014, 8:11 p.m., Ben Mahler wrote:
> > support/release.sh, line 48
> > <https://reviews.apache.org/r/16487/diff/2/?file=403913#file403913line48>
> >
> >     Comment on why we need to do --depth=empty?

done


> On Jan. 10, 2014, 8:11 p.m., Ben Mahler wrote:
> > support/release.sh, line 75
> > <https://reviews.apache.org/r/16487/diff/2/?file=403913#file403913line75>
> >
> >     Any easy way to avoid someone blindly pressing ENTER here?

done


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/#review31535
-----------------------------------------------------------


On Dec. 27, 2013, 8:15 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16487/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-756
>     https://issues.apache.org/jira/browse/MESOS-756
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated the release script (part 3 per MESOS-756).
> 
> 
> Diffs
> -----
> 
>   support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 
> 
> Diff: https://reviews.apache.org/r/16487/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with a dry run.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/#review31535
-----------------------------------------------------------

Ship it!



support/release.sh
<https://reviews.apache.org/r/16487/#comment60050>

    s/Let's download/Downloading/ ? To be consistent with the rest of the script output. (Releasing mesos-....).



support/release.sh
<https://reviews.apache.org/r/16487/#comment60051>

    Checking out the svn ...



support/release.sh
<https://reviews.apache.org/r/16487/#comment60052>

    Comment on why we need to do --depth=empty?



support/release.sh
<https://reviews.apache.org/r/16487/#comment60053>

    Any easy way to avoid someone blindly pressing ENTER here?


- Ben Mahler


On Dec. 27, 2013, 8:15 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16487/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-756
>     https://issues.apache.org/jira/browse/MESOS-756
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated the release script (part 3 per MESOS-756).
> 
> 
> Diffs
> -----
> 
>   support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 
> 
> Diff: https://reviews.apache.org/r/16487/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with a dry run.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/#review31825
-----------------------------------------------------------



support/release.sh
<https://reviews.apache.org/r/16487/#comment60540>

    This folder name should not have the "mesos-" prefix.


- Ben Mahler


On Dec. 27, 2013, 8:15 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16487/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-756
>     https://issues.apache.org/jira/browse/MESOS-756
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated the release script (part 3 per MESOS-756).
> 
> 
> Diffs
> -----
> 
>   support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 
> 
> Diff: https://reviews.apache.org/r/16487/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with a dry run.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 2:47 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benm's. NNFR.


Bugs: MESOS-756
    https://issues.apache.org/jira/browse/MESOS-756


Repository: mesos-git


Description
-------

Updated the release script (part 3 per MESOS-756).


Diffs (updated)
-----

  support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 

Diff: https://reviews.apache.org/r/16487/diff/


Testing
-------

Tested locally with a dry run.


Thanks,

Vinod Kone


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/#review31509
-----------------------------------------------------------



support/release.sh
<https://reviews.apache.org/r/16487/#comment60021>

    Also need to publish a release tag to the git repo.


- Vinod Kone


On Dec. 27, 2013, 8:15 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16487/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 8:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-756
>     https://issues.apache.org/jira/browse/MESOS-756
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated the release script (part 3 per MESOS-756).
> 
> 
> Diffs
> -----
> 
>   support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 
> 
> Diff: https://reviews.apache.org/r/16487/diff/
> 
> 
> Testing
> -------
> 
> Tested locally with a dry run.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 16487: Updated support/release.sh script to upload artifacts after vote.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16487/
-----------------------------------------------------------

(Updated Dec. 27, 2013, 8:15 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

added a prompt for releasing the maven repo.


Bugs: MESOS-756
    https://issues.apache.org/jira/browse/MESOS-756


Repository: mesos-git


Description
-------

Updated the release script (part 3 per MESOS-756).


Diffs (updated)
-----

  support/release.sh 1be2a5fe58a0ba7b1f19d7bf4dcc67b8b8a91afb 

Diff: https://reviews.apache.org/r/16487/diff/


Testing
-------

Tested locally with a dry run.


Thanks,

Vinod Kone