[jira] [Commented] (TWILL-77) Fix BundleJarExample NPE and BundleJarRunner

["Alvin Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TWILL-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010417#comment-14010417 ] 

Alvin Wang commented on TWILL-77:
---------------------------------

Created review request at https://reviews.apache.org/r/21947/

> Fix BundleJarExample NPE and BundleJarRunner
> --------------------------------------------
>
>                 Key: TWILL-77
>                 URL: https://issues.apache.org/jira/browse/TWILL-77
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: ext
>    Affects Versions: 0.3.0-incubating
>            Reporter: Alvin Wang
>            Assignee: Alvin Wang
>
> From Alex Chin,
> 1. The bundle jar path (e.g. $HOME/my-app.jar) will be used as both the path to find the jar on the local filesystem and as the path to find the jar in the unpacked, localized archive from within YARN. So, without changing BundledJarExample or BundledJarRunner, the easiest way of meeting both these criteria is to make sure your bundle jar is in the current working directory.
> 2. BundledJarExample actually takes 4 mandatory arguments, not just 3. You must specify the ZooKeeper ensemble, the bundle jar, a library directory, and a main class. Once I added the library directory argument, it worked. It looks like BundledJarExample needs to be updated to match the arguments BundledJarRunner accepts.
> --
> Needed changes:
> 1. Instead of unpacking application jar and then adding both the original application jar and the jars within the libFolder directory inside the unpacked jar directory, BundledJarRunner should add ./, ./\*.jar, and ./lib/\*.jar within the unpacked jar directory to the classpath.
> 2. Remove required library directory argument from BundledJarExample and BundledJarRunner.
> 3. Add optional additional library directories to BundledJarRunner, in addition to ./\*.jar and ./lib/\*.jar.
> 4. Add better validations so that errors indicate a clear root cause.



--
This message was sent by Atlassian JIRA
(v6.2#6252)