[lucene-solr] branch reference_impl_dev updated: @755 These asserts don't fail tests and just cause bs differences with prod by throwing Errors.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new efc512e  @755 These asserts don't fail tests and just cause bs differences with prod by throwing Errors.
efc512e is described below

commit efc512e64ce1eaf7dff0116fc9e158a8785f1b36
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sat Sep 5 21:17:14 2020 -0500

    @755 These asserts don't fail tests and just cause bs differences with prod by throwing Errors.
---
 solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java b/solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java
index 0cc50e5..abcfbfa 100644
--- a/solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java
+++ b/solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java
@@ -202,7 +202,6 @@ public abstract class CachingDirectoryFactory extends DirectoryFactory {
                 this.getClass().getSimpleName(), val);
         try {
           // if there are still refs out, we have to wait for them
-          assert val.refCnt > -1 : val.refCnt + " path=" + val.path;
           while (val.refCnt != 0) {
             wait(250);
 
@@ -214,7 +213,6 @@ public abstract class CachingDirectoryFactory extends DirectoryFactory {
               throw new SolrException(ErrorCode.SERVER_ERROR, msg);
             }
           }
-          assert val.refCnt == 0 : val.refCnt;
         } catch (InterruptedException e) {
           ParWork.propegateInterrupt("Interrupted closing directory", e);
           return;
@@ -228,7 +226,6 @@ public abstract class CachingDirectoryFactory extends DirectoryFactory {
       for (CacheValue val : values) {
         try {
           for (CacheValue v : val.closeEntries) {
-            assert v.refCnt == 0 : val.refCnt;
             if (log.isDebugEnabled()) log.debug("Closing directory when closing factory: " + v.path);
             boolean cl = closeCacheValue(v);
             if (cl) {
@@ -565,8 +562,6 @@ public abstract class CachingDirectoryFactory extends DirectoryFactory {
       //    }
       cacheValue.refCnt--;
 
-      assert cacheValue.refCnt >= 0 : cacheValue.refCnt;
-
       if (cacheValue.refCnt == 0 && cacheValue.doneWithDir) {
         boolean cl = closeCacheValue(cacheValue);
         if (cl) {