You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/08/15 00:57:45 UTC
[GitHub] [incubator-tvm] electriclilies opened a new pull request #6284: [RELAY][DYN] Implementation of the dynamic pad operator
electriclilies opened a new pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284
Implementation of the dynamic pad operator
@mbrookhart @zhiics please take a look and let me know if you have any suggestions
Also, clang-format changed a bunch of stuff in include/tvm/relay/attrs/nn.h -- what files are supposed to be formatted using clang-format?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #6284: [RELAY][DYN] Implementation of the dynamic pad operator
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on a change in pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284#discussion_r472355129
##########
File path: python/tvm/relay/op/nn/nn.py
##########
@@ -1147,13 +1149,13 @@ def upsampling(data,
Parameters
----------
- data : tvm.relay.Expr
+ data : tvm.relay.Expr or tuple<anytype> or list<anytype>
Review comment:
I don't think data can be a tuple or list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] electriclilies commented on pull request #6284: [RELAY][DYN] Implementation of the dynamic pad operator
Posted by GitBox <gi...@apache.org>.
electriclilies commented on pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284#issuecomment-675194479
@zhiics @icemelon9 @mbrookhart had a few bugs on this, but it's good to go now! Please let me know what you think. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6284: [RELAY][DYN] Implementation of the dynamic pad operator
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6284: [RELAY][DYN] Implementation of the dynamic pad operator
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6284:
URL: https://github.com/apache/incubator-tvm/pull/6284#issuecomment-676850427
Thanks @mbrookhart @electriclilies !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org