You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/05/04 00:42:33 UTC
[GitHub] bookkeeper pull request #135: BOOKKEEPER-1045: Execute tests in different JV...
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/135
BOOKKEEPER-1045: Execute tests in different JVM processes
The current Maven Surefire configuration is using:
```xml
<forkMode>always</forkMode>
```
This is a deprecated config and apparently it's not creating new processes for each test as intended.
Currently the tests are leaking a big number of files and threads due to several reasons:
* Tests that instantiate bookies and call shutdown() without calling start() before are creating and initializing the ledger storage but not closing it, leaking threads and several fds
* ZooKeeperClient sometimes doesn't shutdown the zk handle if the test completes too quickly, leaking sockets.
* Several tests are passing bad config, so the bookie/client start gets exception (on purpose) and then doesn't clean up some partial objects.
* ...
That make running the test suite to be dependent on ulimit of the machine.
Until we can fix (almost) all the test to do proper cleanup, we should make maven to run tests in separated processes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper bk-1045-test-forks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit da0aece16a91550130854aa23dd2e5b5efec175a
Author: Matteo Merli <mm...@apache.org>
Date: 2017-05-04T00:39:50Z
BOOKKEEPER-1045: Execute tests in different JVM processes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #135: BOOKKEEPER-1045: Execute tests in different JVM proce...
Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:
https://github.com/apache/bookkeeper/pull/135
@eolivelli we can try with `<forkCount>1C</forkCount>` to spawn 1 process per core and run the tests in parallel.
I didn't do that at this point since I don't want to chase after any new test issues :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #135: BOOKKEEPER-1045: Execute tests in different JV...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---