You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2016/05/25 21:31:12 UTC
[jira] [Closed] (BEAM-249) Combine.GroupedValues re-wraps combineFn
from Combine.PerKey and loses identity for DisplayData
[ https://issues.apache.org/jira/browse/BEAM-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Wegner closed BEAM-249.
-----------------------------
Resolution: Fixed
Done
> Combine.GroupedValues re-wraps combineFn from Combine.PerKey and loses identity for DisplayData
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-249
> URL: https://issues.apache.org/jira/browse/BEAM-249
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
>
> Combine.PerKey is implemented in terms of Combine.GroupedValues, but it passed as wrapped combineFn which gets re-wrapped in Combine.GroupedValues. As a result, we lose the identity of the original combineFn for display data.
> We should update the API to also pass the original identity downstream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)