You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/08 04:18:22 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

nvazquez opened a new pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062


   ## Description
   
   Logs:
   ````
   2020-05-07 23:12:28,116 INFO  [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80 ctx-a3fc4a74) (logid:936f1123) Migrating VM[User|i-2-8-VM] to Dest[Zone(Id)-Pod(Id)-Cluster(Id)-Host(Id)-Storage(Volume(Id|Type-->Pool(Id))] : Dest[Zone(1)-Pod(1)-Cluster(1)-Host(2)-Storage()]
   2020-05-07 23:12:28,120 DEBUG [c.c.n.NetworkModelImpl] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80 ctx-a3fc4a74) (logid:936f1123) Service SecurityGroup is not supported in the network id=210
   2020-05-07 23:12:28,125 DEBUG [c.c.n.NetworkModelImpl] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80 ctx-a3fc4a74) (logid:936f1123) Service SecurityGroup is not supported in the network id=210
   2020-05-07 23:12:28,127 ERROR [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80 ctx-a3fc4a74) (logid:936f1123) Invocation exception, caused by: java.lang.ClassCastException: class com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 cannot be cast to class com.cloud.vm.UserVmVO (com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 and com.cloud.vm.UserVmVO are in unnamed module of loader 'app')
   2020-05-07 23:12:28,127 INFO  [c.c.v.VmWorkJobHandlerProxy] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80 ctx-a3fc4a74) (logid:936f1123) Rethrow exception java.lang.ClassCastException: class com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 cannot be cast to class com.cloud.vm.UserVmVO (com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 and com.cloud.vm.UserVmVO are in unnamed module of loader 'app')
   2020-05-07 23:12:28,127 DEBUG [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80) (logid:936f1123) Done with run of VM work job: com.cloud.vm.VmWorkMigrate for VM 8, job origin: 79
   2020-05-07 23:12:28,127 ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-25:ctx-0a8703ef job-79/job-80) (logid:936f1123) Unable to complete AsyncJobVO {id:80, userId: 2, accountId: 2, instanceType: null, instanceId: null, cmd: com.cloud.vm.VmWorkMigrate, cmdInfo: rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAAAAAAAAAACAAAAAAAAAAIAAAAAAAAACHQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAAXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAAAAAAAAAXNxAH4ABwAAAAAAAAACcQB-AAlwcQB-AAk, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32989593536621, completeMsid: null, lastUpdated: null, lastPolled: null, created: Thu May 07 23:12:27 UTC 2020, removed: null}, job origin:79
   java.lang.ClassCastException: class com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 cannot be cast to class com.cloud.vm.UserVmVO (com.cloud.vm.VMInstanceVO$$EnhancerByCGLIB$$1786dcb5 and com.cloud.vm.UserVmVO are in unnamed module of loader 'app')
   	at com.cloud.network.element.VirtualRouterElement.prepareMigration(VirtualRouterElement.java:1226)
   	at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNicForMigration(NetworkOrchestrator.java:1778)
   	at com.cloud.vm.VirtualMachineManagerImpl.migrate(VirtualMachineManagerImpl.java:2358)
   
   ````
   
   Strangely, assert check passes but casting fails:
   ````
   } else if (vm.getType() == VirtualMachine.Type.User) {
               assert vm instanceof UserVmVO;
               final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();
               _userVmMgr.setupVmForPvlan(false, userVm.getHostId(), nic);
   }`
   ````
   
   
   Fixes: #4061 
   
   ## Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ![image](https://user-images.githubusercontent.com/5295080/81333676-50407480-907b-11ea-9ad5-f853184c3386.png)
   
   ## How Has This Been Tested?
   Deploy VM on Shared network - PVLAN
   Migrate VM to another host
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638583121


   Packaging result: ✔centos7 ✔debian. JID-1281


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425173131



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       @nvazquez Have you observed similar issues with router VM using similar type casting in the if stmt above. eg: `DomainRouterVO router = (DomainRouterVO) vm.getVirtualMachine();`. Same casting is being used for router VM in other methods below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425173131



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       @nvazquez Have you observed similar issues with router VM using similar type casting in the if stmt above. eg: `DomainRouterVO router = (DomainRouterVO) vm.getVirtualMachine();`. Same casting is being used for router VM in other methods below. May be you have to fix the same for router VM as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629371491


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625627136


   Packaging result: ✔centos7 ✔debian. JID-1218


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638594518


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625957770


   <b>Trillian test result (tid-1513)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47302 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4062-t1513-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 423.07 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 417.00 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 291.52 | test_vpc_vpn.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425173131



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       @nvazquez Have you observed similar issues with router VM using similar type casting in the if stmt above. eg: `DomainRouterVO router = (DomainRouterVO) vm.getVirtualMachine();`. Same casting is being used for router VM in other methods below. May be you can check and fix for router VM as well. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625621213


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638594131


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625630673


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-639871635


   <b>Trillian test result (tid-1628)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 60400 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4062-t1628-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 55 look OK, 22 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 185.33 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 180.19 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 239.32 | test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.34 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.35 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.38 | test_templates.py
   test_02_deploy_vm_from_direct_download_template | `Error` | 1.19 | test_templates.py
   test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 16.63 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
   ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
   test_14_secure_to_secure_vm_migration | `Error` | 11.26 | test_vm_life_cycle.py
   test_15_secured_to_nonsecured_vm_migration | `Error` | 104.05 | test_vm_life_cycle.py
   test_16_nonsecured_to_secured_vm_migration | `Error` | 1.16 | test_vm_life_cycle.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.58 | test_vm_snapshots.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1511.98 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-639995458


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-639995728


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629405248


   Packaging result: ✔centos7 ✔debian. JID-1228


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625630386


   @blueorangutan test centos7 vmware-67u3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425935527



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       Thanks @sureshanaparti. I have not observed errors in those other castings but will be nice to solve the problem instead of the workaround I'm proposing in this fix, will take a look into that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-629371824


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd removed a comment on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638560711


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638561047


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-640078357


   <b>Trillian test result (tid-1636)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29960 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4062-t1636-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 182.81 | test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 180.25 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 249.68 | test_privategw_acl.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638561431


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638560711


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-625621436


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org