You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/08/23 08:03:36 UTC
[GitHub] [hadoop] jojochuang commented on a change in pull request #3315: HDFS-16180.FsVolumeImpl.nextBlock should consider that the block meta file has been deleted
jojochuang commented on a change in pull request #3315:
URL: https://github.com/apache/hadoop/pull/3315#discussion_r693287224
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeImpl.java
##########
@@ -865,7 +866,15 @@ public ExtendedBlock nextBlock() throws IOException {
}
File blkFile = getBlockFile(bpid, block);
- File metaFile = FsDatasetUtil.findMetaFile(blkFile);
+ File metaFile ;
+ try {
+ metaFile = FsDatasetUtil.findMetaFile(blkFile);
+ } catch (FileNotFoundException e){
+ LOG.warn("nextBlock({}, {}): {}", storageID, bpid,
Review comment:
can you make the log message more explicit? Like "Metadata file for block file is missing. Skip it"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org