You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/18 22:14:37 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #4986: Lookup CSS properties case-insensitive
matthiasblaesing opened a new pull request, #4986:
URL: https://github.com/apache/netbeans/pull/4986
Closes: #4861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #4986:
URL: https://github.com/apache/netbeans/pull/4986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
lbownik commented on code in PR #4986:
URL: https://github.com/apache/netbeans/pull/4986#discussion_r1031360206
##########
ide/css.editor/src/org/netbeans/modules/css/editor/module/main/BrowserSupportModule.java:
##########
@@ -66,7 +66,12 @@ public Collection<String> getPropertyNames(FileObject file) {
@Override
public PropertyDefinition getPropertyDefinition(String propertyName) {
- return parser.getVendorSpecificProperties().get(propertyName);
+ PropertyDefinition pd = parser.getVendorSpecificProperties().get(propertyName);
Review Comment:
ok - good
just saw a lack of null check and though there might be some potential NullPointer there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #4986:
URL: https://github.com/apache/netbeans/pull/4986#discussion_r1028489850
##########
ide/css.editor/src/org/netbeans/modules/css/editor/module/main/BrowserSupportModule.java:
##########
@@ -66,7 +66,12 @@ public Collection<String> getPropertyNames(FileObject file) {
@Override
public PropertyDefinition getPropertyDefinition(String propertyName) {
- return parser.getVendorSpecificProperties().get(propertyName);
+ PropertyDefinition pd = parser.getVendorSpecificProperties().get(propertyName);
Review Comment:
I don't understand what is the relevance of this question. If there was a problem before this change it is still there. This is not the point of the changeset.
To answer the question: `BrowserSpecificDefinitionParser#getVendorSpecificProperties` is backed by a `HashSet`. This allows `null` as key. The parser though will not yield `null` keys, so the `null` will not have a backing value, yielding `null` fro the `PropertyDefinition`. This in turn is caught in the new line 70, which explicitly checks for `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on a diff in pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
lbownik commented on code in PR #4986:
URL: https://github.com/apache/netbeans/pull/4986#discussion_r1027799361
##########
ide/css.editor/src/org/netbeans/modules/css/editor/module/main/BrowserSupportModule.java:
##########
@@ -66,7 +66,12 @@ public Collection<String> getPropertyNames(FileObject file) {
@Override
public PropertyDefinition getPropertyDefinition(String propertyName) {
- return parser.getVendorSpecificProperties().get(propertyName);
+ PropertyDefinition pd = parser.getVendorSpecificProperties().get(propertyName);
Review Comment:
what is the result of this execution if propertyName is null? can it ever be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4986:
URL: https://github.com/apache/netbeans/pull/4986#issuecomment-1320588963
Testbuild: https://doppel-helix.eu/NetBeans-dev-dev-6f2056b4929fc2089418b487defec1b4150efefa-release.zip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed pull request #4986: Lookup CSS properties case-insensitive
Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed pull request #4986: Lookup CSS properties case-insensitive
URL: https://github.com/apache/netbeans/pull/4986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists