You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/02/11 08:54:28 UTC
Review Request 72107: Fixed Windows command argument stringification.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72107/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Benjamin Bannier.
Bugs: MESOS-10093
https://issues.apache.org/jira/browse/MESOS-10093
Repository: mesos
Description
-------
Fixed Windows command argument stringification.
Diffs
-----
3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23
Diff: https://reviews.apache.org/r/72107/diff/1/
Testing
-------
Tested manually by launching a docker task with the following command:
```
python -c "import time\nwhile True:\n time.sleep(5)\n print('hello world')"
```
Thanks,
Greg Mann
Re: Review Request 72107: Fixed Windows command argument
stringification.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72107/#review219538
-----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 218 (patched)
<https://reviews.apache.org/r/72107/#comment307729>
Please add a test for this.
3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 219-223 (patched)
<https://reviews.apache.org/r/72107/#comment307728>
This is a strange loop and it took me a while to digest.
Could we instead just perform the escaping inside the loop above where we already perform some escaping? You could even introduce a small helper if you wanted.
- Benjamin Bannier
On Feb. 11, 2020, 9:54 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72107/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2020, 9:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
>
>
> Bugs: MESOS-10093
> https://issues.apache.org/jira/browse/MESOS-10093
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Windows command argument stringification.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23
>
>
> Diff: https://reviews.apache.org/r/72107/diff/1/
>
>
> Testing
> -------
>
> Tested manually by launching a docker task with the following command:
>
> ```
> python -c "import time\nwhile True:\n time.sleep(5)\n print('hello world')"
> ```
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72107: Fixed Windows command argument
stringification.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72107/#review219539
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72107]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Feb. 11, 2020, 8:54 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72107/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2020, 8:54 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Benjamin Bannier.
>
>
> Bugs: MESOS-10093
> https://issues.apache.org/jira/browse/MESOS-10093
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed Windows command argument stringification.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/shell.hpp 2f76bbaac9032906c544010c55cdcbe3d7b03d23
>
>
> Diff: https://reviews.apache.org/r/72107/diff/1/
>
>
> Testing
> -------
>
> Tested manually by launching a docker task with the following command:
>
> ```
> python -c "import time\nwhile True:\n time.sleep(5)\n print('hello world')"
> ```
>
>
> Thanks,
>
> Greg Mann
>
>