You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/07 13:38:37 UTC

[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #1219: WIP: persist the cluster nodes info

torwig commented on code in PR #1219:
URL: https://github.com/apache/incubator-kvrocks/pull/1219#discussion_r1064005199


##########
src/config/config.h:
##########
@@ -194,6 +194,7 @@ struct Config {
   mutable std::mutex backup_mu_;
 
  public:
+  const std::string NodesFilePath();

Review Comment:
   Did you mean `std::string NodesFilePath() const;`? Because, in my opinion, it makes no sense to return std::string by value and apply const-modifier to that value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org