You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/02 20:50:33 UTC

[GitHub] MaxGekk opened a new pull request #23431: [SPARK-26023][SQL][FOLLOWUP] Dumping truncated plans and generated code to a file

MaxGekk opened a new pull request #23431: [SPARK-26023][SQL][FOLLOWUP] Dumping truncated plans and generated code to a file
URL: https://github.com/apache/spark/pull/23431
 
 
   ## What changes were proposed in this pull request?
   
   `DataSourceScanExec` overrides "wrong" `treeString` method without `append`. In the PR, I propose to make `treeString`s **final** to prevent such mistakes in the future. And removed the `treeString` and `verboseString` since they both use `simpleString` with reduction.
   
   ## How was this patch tested?
   
   It was tested by `DataSourceScanExecRedactionSuite`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org