[GitHub] [fineract] adamsaghy commented on a diff in pull request #2760: FINERACT-1819: Fix for GL entries for Credit Balance Refund transaction

[GitBox <gi...@apache.org>]

adamsaghy commented on code in PR #2760:
URL: https://github.com/apache/fineract/pull/2760#discussion_r1031632171


##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -569,8 +569,8 @@ private void createJournalEntriesForCreditBalanceRefund(final LoanDTO loanDTO, f
         final boolean isReversal = loanTransactionDTO.isReversed();
         final Long paymentTypeId = loanTransactionDTO.getPaymentTypeId();
 
-        this.helper.createJournalEntriesAndReversalsForLoan(office, currencyCode, AccrualAccountsForLoan.LOAN_PORTFOLIO.getValue(),
-                AccrualAccountsForLoan.OVERPAYMENT.getValue(), loanProductId, paymentTypeId, loanId, transactionId, transactionDate,
+        this.helper.createJournalEntriesAndReversalsForLoan(office, currencyCode, AccrualAccountsForLoan.OVERPAYMENT.getValue(),
+                AccrualAccountsForLoan.LOAN_PORTFOLIO.getValue(), loanProductId, paymentTypeId, loanId, transactionId, transactionDate,

Review Comment:
   Based on the jira ticket, it should use the Fund source, not the loan portfolio. Am i missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org