[GitHub] [flink] fredia commented on a diff in pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

[GitBox <gi...@apache.org>]

fredia commented on code in PR #20965:
URL: https://github.com/apache/flink/pull/20965#discussion_r996599726


##########
flink-state-backends/flink-statebackend-common/src/main/java/org/apache/flink/state/common/PeriodicMaterializationManager.java:
##########
@@ -251,6 +254,8 @@ private void asyncMaterializationPhase(
                                                 target.handleMaterializationResult(
                                                         snapshotResult, materializationID, upTo);
                                                 metrics.reportCompletedMaterialization();
+                                                metrics.reportMaterializationDuration(

Review Comment:
   I think it's a little confusing to mix `successed` and `failed` together.  In fact, the failed materialization duration is meaningless, for me, I prefer to keep `lastMaterializationDuration` and `lastIncSizeOfMaterialization/lastFullSizeOfMaterialization`  consistent. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org