You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by rerngvit <gi...@git.apache.org> on 2016/06/23 22:18:51 UTC

[GitHub] zeppelin pull request #1077: [ZEPPELIN-921] Apply new mechanism to KnitR and...

GitHub user rerngvit opened a pull request:

    https://github.com/apache/zeppelin/pull/1077

    [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

    ### What is this PR for?
    This PR applies the new interpreter registration mechanism to KnitR and RRepl.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - Move interpreter registration properties from static block to interpreter-setting.json
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-921
    
    ### How should this be tested?
    1. apply patch
    2. rm -r interpreter/r
    3. rm conf/interpreter.json
    4. mvn clean package -DskipTests -Pspark-1.6 -Psparkr
    5. bin/zeppelin-daemon.sh start
    6. run some paragraph with simple R queries
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-921

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1077.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1077
    
----
commit 460ec8dfc548ab71f94ddae83991bfe191602a2f
Author: rerngvit <re...@kth.se>
Date:   2016-06-10T06:45:01Z

    [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
    
    This PR applies the new interpreter registration mechanism to KnitR and RRepl.
    
    Improvement
    
    - Move interpreter registration properties from static block to interpreter-setting.json
    
    https://issues.apache.org/jira/browse/ZEPPELIN-921
    
    1. apply patch
    2. rm -r interpreter/r
    3. rm conf/interpreter.json
    4. mvn clean package -DskipTests -Pspark-1.6 -Psparkr
    5. bin/zeppelin-daemon.sh start
    6. run some paragraph with simple R queries
    
    Questions:
    
    Does the licenses files need update? No
    Is there breaking changes for older versions? No
    Does this needs documentation? No

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1077: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1077
  
    @rerngvit How about stopping Zeppelin, removing conf/interpreter.json, starting Zeppelin and testing it again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1077: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1077
  
    @rerngvit I'm not good at R, if you, however, built with `-Pr` and got an error while creating interpreter, AFAIK, you should have a R installed by default. Could you please check this first?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1077: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

Posted by elbamos <gi...@git.apache.org>.

Github user elbamos commented on the issue:

    https://github.com/apache/zeppelin/pull/1077
  
    I'm sorry I have not had a chance to finish addressing this. One issue is that a PR to interpreter.sh removed the rinterpreter jar from the classpath. It needs to be put back in. That will cause knitr to work. The second issue is that the other spark interpreter is hardcoded into the configuration files I believe related to livy - so it ignores the registration for rrepl as spark.r. 
    
    > On Jul 5, 2016, at 5:38 PM, Rerngvit Yanggratoke <no...@github.com> wrote:
    > 
    > I think I found the root cause of the problem. The key issue is that currently the build configuration packages "zeppelin-zrinterpreter-0.6.0-SNAPSHOT.jar" under "interpreter/spark" instead of under "interpreter/r" (as similar to other interpreter like "flink" or "sh"). Then, when the registration process is done at "InterpreterFactory.java" method "registerInterpreterFromResource" takes the "interpreter-setting.json" from "zeppelin-spark-0.6.0-SNAPSHOT.jar". I will try change this configuration and see whether it addressed the issue.
    > 
    > \u2014
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---