[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1173: [KYUUBI #1008][FOLLOWUP] No need to send private token from Kyuubi server to engine

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #1173:
URL: https://github.com/apache/incubator-kyuubi/pull/1173#discussion_r717652959



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/util/KyuubiHadoopUtils.scala
##########
@@ -76,19 +69,6 @@ object KyuubiHadoopUtils {
     creds
   }
 
-  /**
-   * Get all tokens in [[UserGroupInformation#subject]] including
-   * [[org.apache.hadoop.security.token.Token.PrivateToken]] as
-   * [[UserGroupInformation#getCredentials]] returned Credentials do not contain
-   * [[org.apache.hadoop.security.token.Token.PrivateToken]].
-   */
-  def getCredentialsInternal(ugi: UserGroupInformation): Credentials = {
-    // Synchronize to avoid credentials being written while cloning credentials
-    subjectField.get(ugi).asInstanceOf[Subject] synchronized {

Review comment:
       rm subjectField too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org