[GitHub] [druid] somu-imply commented on a diff in pull request #13965: Planning correctly for order by queries on time which previously thre…

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #13965:
URL: https://github.com/apache/druid/pull/13965#discussion_r1145293604


##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -1448,15 +1449,6 @@ private ScanQuery toScanQuery()
         );
         return null;
       }
-      if (!dataSource.isConcrete()) {

Review Comment:
   This was a change in #12418 that was reverted. Since we are using a table data source and not a query data source now the isConcrete() check is not needed and can be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org