[GitHub] [airflow] lyso commented on a diff in pull request #29602: Change config max tis per query

["lyso (via GitHub)" <gi...@apache.org>]

lyso commented on code in PR #29602:
URL: https://github.com/apache/airflow/pull/29602#discussion_r1125442443


##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -1120,11 +1120,12 @@ catchup_by_default = True
 ignore_first_depends_on_past_by_default = True
 
 # This changes the batch size of queries in the scheduling main loop.
+# This should not be greater than ``core.parallelism``.
 # If this is too high, SQL query performance may be impacted by
 # complexity of query predicate, and/or excessive locking.
 # Additionally, you may hit the maximum allowable query length for your db.
-# Set this to 0 for no limit (not advised)
-max_tis_per_query = 512
+# Setting this to 0 for using the value of ``core.parallelism``
+max_tis_per_query = 16

Review Comment:
   emits a warning would be a good suggestion. I have not find if Airflow have implemented such utils to generate such warning in case a conf value is greater than another one, like [``deprecate_warn``](https://github.com/apache/airflow/blob/c53a3e153f0ab5ca933a94adc01dc6314ea8d4d1/airflow/configuration.py#L1245)
   
   Do you know if we have such helper function implemented?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org