[GitHub] [pulsar] horizonzy commented on a diff in pull request #12396: Fix NPE when create OpEntry

[GitBox <gi...@apache.org>]

horizonzy commented on code in PR #12396:
URL: https://github.com/apache/pulsar/pull/12396#discussion_r847185365


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2154,6 +2154,7 @@ PositionImpl startReadOperationOnLedger(PositionImpl position, OpReadEntry opRea
         if (null == ledgerId) {
             opReadEntry.readEntriesFailed(new ManagedLedgerException.NoMoreEntriesToReadException("The ceilingKey(K key) method is used to return the " +
                     "least key greater than or equal to the given key, or null if there is no such key"), null);

Review Comment:
   still npe, can't pass on null ctx, in the process of callback, need use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org