You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/01/10 10:49:00 UTC

[jira] [Commented] (RATIS-789) ConcurrentModification in MetricsRegistriesImpl

    [ https://issues.apache.org/jira/browse/RATIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012706#comment-17012706 ] 

Hadoop QA commented on RATIS-789:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m  6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 58m 49s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 13s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.impl.TestArchiveHdfsLogReaderAndWriter |
|   | ratis.grpc.TestServerRestartWithGrpc |
|   | ratis.netty.TestRaftExceptionWithNetty |
|   | ratis.netty.TestGroupManagementWithNetty |
|   | ratis.netty.TestLogAppenderWithNetty |
|   | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.netty.TestRaftSnapshotWithNetty |
|   | ratis.netty.TestRaftWithNetty |
|   | ratis.netty.TestGroupInfoWithNetty |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.TestMultiRaftGroup |
|   | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2020-01-10 |
| JIRA Issue | RATIS-789 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12990499/RATIS-789.001.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  checkstyle  compile  |
| uname | Linux cc5da18795c8 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh |
| git revision | master / fd7091c |
| maven | version: Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/1205/artifact/out/patch-unit-root.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/1205/testReport/ |
| Max. process+thread count | 1340 (vs. ulimit of 5000) |
| modules | C: ratis-metrics U: ratis-metrics |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/1205/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> ConcurrentModification in MetricsRegistriesImpl
> -----------------------------------------------
>
>                 Key: RATIS-789
>                 URL: https://issues.apache.org/jira/browse/RATIS-789
>             Project: Ratis
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>         Attachments: RATIS-789.001.patch
>
>
> {code}
> java.util.ConcurrentModificationException
> 	at java.util.ArrayList.forEach(ArrayList.java:1260)
> 	at org.apache.ratis.metrics.impl.MetricRegistriesImpl.lambda$create$1(MetricRegistriesImpl.java:66)
> 	at org.apache.ratis.metrics.impl.RefCountingMap.lambda$put$0(RefCountingMap.java:51)
> 	at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> 	at org.apache.ratis.metrics.impl.RefCountingMap.put(RefCountingMap.java:46)
> 	at org.apache.ratis.metrics.impl.MetricRegistriesImpl.create(MetricRegistriesImpl.java:59)
> 	at org.apache.ratis.server.metrics.RatisMetrics.create(RatisMetrics.java:45)
> 	at org.apache.ratis.server.metrics.RatisMetrics.getMetricRegistryForLogAppender(RatisMetrics.java:82)
> 	at org.apache.ratis.server.metrics.LogAppenderMetrics.<init>(LogAppenderMetrics.java:32)
> 	at org.apache.ratis.server.impl.LeaderState.<init>(LeaderState.java:221)
> 	at org.apache.ratis.server.impl.RoleInfo.startLeaderState(RoleInfo.java:94)
> 	at org.apache.ratis.server.impl.RaftServerImpl.changeToLeader(RaftServerImpl.java:348)
> 	at org.apache.ratis.server.impl.LeaderElection.askForVotes(LeaderElection.java:238)
> 	at org.apache.ratis.server.impl.LeaderElection.run(LeaderElection.java:161)
> {code}
> (RATIS-788 has more details, if needed)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)