You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/12/07 09:36:18 UTC

[GitHub] [guacamole-server] benrubson commented on a change in pull request #314: GUACAMOLE-1110: Create a proper dedicated service group

benrubson commented on a change in pull request #314:
URL: https://github.com/apache/guacamole-server/pull/314#discussion_r537358680



##########
File path: Dockerfile
##########
@@ -115,7 +115,8 @@ HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1 4822 || exit 1
 
 # Create a new user guacd
 ARG UID=1000
-RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --no-user-group guacd
+RUN groupadd --gid $UID guacd
+RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --gid $UID guacd

Review comment:
       Many thanks for your feedback @mike-jumper, updated accordingly :+1:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org