[tomcat] branch 8.5.x updated: Fix (hopefully) intermittent Gump failure

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 5d0da14  Fix (hopefully) intermittent Gump failure
5d0da14 is described below

commit 5d0da1447367dbd1c98f2fcbe674f5d55e4be2c5
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Feb 17 16:57:57 2020 +0000

    Fix (hopefully) intermittent Gump failure
    
    result needs to be volatile because it is written from the container
    thread and read from the test thread (like done)
---
 test/org/apache/catalina/core/TestAsyncContextImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/catalina/core/TestAsyncContextImpl.java b/test/org/apache/catalina/core/TestAsyncContextImpl.java
index 31942f5..b80c29a 100644
--- a/test/org/apache/catalina/core/TestAsyncContextImpl.java
+++ b/test/org/apache/catalina/core/TestAsyncContextImpl.java
@@ -311,7 +311,7 @@ public class TestAsyncContextImpl extends TomcatBaseTest {
 
         private volatile boolean done = false;
 
-        private StringBuilder result;
+        private volatile StringBuilder result;
 
         public static final long THREAD_SLEEP_TIME = 1000;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org