You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/01/23 18:47:02 UTC

Review Request 30219: AMS: certain metric charts look incorrect

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30219/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-9305
    https://issues.apache.org/jira/browse/AMBARI-9305


Repository: ambari


Description
-------

Garbage collection time (on HDFS and YARN, not sure if there are others) look incorrect.
HDFS I/O metrics chart (bytes written and read) look incorrect


Diffs
-----

  ambari-metrics/ambari-metrics-common/pom.xml 7bfd9f1 
  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 5e89e14 
  ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java PRE-CREATION 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a8d3a37 

Diff: https://reviews.apache.org/r/30219/diff/


Testing
-------

tests passed


Thanks,

Dmytro Sen


Re: Review Request 30219: AMS: certain metric charts look incorrect

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30219/#review69418
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Січ. 23, 2015, 7:47 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30219/
> -----------------------------------------------------------
> 
> (Updated Січ. 23, 2015, 7:47 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-9305
>     https://issues.apache.org/jira/browse/AMBARI-9305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Garbage collection time (on HDFS and YARN, not sure if there are others) look incorrect.
> HDFS I/O metrics chart (bytes written and read) look incorrect
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 7bfd9f1 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java 5e89e14 
>   ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java PRE-CREATION 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a8d3a37 
> 
> Diff: https://reviews.apache.org/r/30219/diff/
> 
> 
> Testing
> -------
> 
> tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>