You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/28 03:32:06 UTC

[GitHub] [flink] hehuiyuan opened a new pull request #13495: Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

hehuiyuan opened a new pull request #13495:
URL: https://github.com/apache/flink/pull/13495


   
   ## What is the purpose of the change
   
   To make case demo more obvious.
   Change
   
   ![image](https://user-images.githubusercontent.com/18002496/94387913-2567d180-017e-11eb-9adb-44e3167cca38.png)
   
   To
   
   ![image](https://user-images.githubusercontent.com/18002496/94387868-00735e80-017e-11eb-8529-f6af47bf2c79.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014) 
   * d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699750515


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 (Mon Sep 28 03:33:41 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111",
       "triggerID" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699914788


   ```
   [INFO] Running org.apache.flink.table.runtime.batch.sql.UnnestITCase
   [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.266 s - in org.apache.flink.table.runtime.batch.sql.UnnestITCase
   [INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 80.312 s - in org.apache.flink.table.planner.runtime.batch.sql.OverWindowITCase
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   AggregateITCase.testListAggWithDistinct:667 expected:<List(1,A, 2,B, 3,C#A, 4,EF)> but was:<List(1,A, 2,B, 3,C#A, 4,EF#EF)>
   [INFO] 
   [ERROR] Tests run: 2744, Failures: 1, Errors: 0, Skipped: 22
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO]
   ```
   
   
   ![image](https://user-images.githubusercontent.com/18002496/94419945-05540480-01b6-11eb-9956-2c70467106d9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111",
       "triggerID" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699750515


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c (Fri Feb 19 07:31:51 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **Invalid pull request title: No valid Jira ID provided**
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699919277


   ![image](https://user-images.githubusercontent.com/18002496/94420850-51537900-01b7-11eb-986f-92cad351502d.png)
   
   ```
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   AggregateITCase.testListAggWithDistinct:667 expected:<List(1,A, 2,B, 3,C#A, 4,EF)> but was:<List(1,A, 2,B, 3,C#A, 4,EF#EF)>
   [INFO] 
   [ERROR] Tests run: 2744, Failures: 1, Errors: 0, Skipped: 22
   [INFO]
   ```
   
   @rmetzger There is a problem for other case


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan removed a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan removed a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699914788


   ```
   [INFO] Running org.apache.flink.table.runtime.batch.sql.UnnestITCase
   [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.266 s - in org.apache.flink.table.runtime.batch.sql.UnnestITCase
   [INFO] Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 80.312 s - in org.apache.flink.table.planner.runtime.batch.sql.OverWindowITCase
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   AggregateITCase.testListAggWithDistinct:667 expected:<List(1,A, 2,B, 3,C#A, 4,EF)> but was:<List(1,A, 2,B, 3,C#A, 4,EF#EF)>
   [INFO] 
   [ERROR] Tests run: 2744, Failures: 1, Errors: 0, Skipped: 22
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO]
   ```
   
   
   ![image](https://user-images.githubusercontent.com/18002496/94419945-05540480-01b6-11eb-9956-2c70467106d9.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-701164789


   @flinkbot test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-701178023


   @flinkbot re-run


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hehuiyuan commented on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
hehuiyuan commented on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699919277


   ![image](https://user-images.githubusercontent.com/18002496/94420850-51537900-01b7-11eb-986f-92cad351502d.png)
   
   ```
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   AggregateITCase.testListAggWithDistinct:667 expected:<List(1,A, 2,B, 3,C#A, 4,EF)> but was:<List(1,A, 2,B, 3,C#A, 4,EF#EF)>
   [INFO] 
   [ERROR] Tests run: 2744, Failures: 1, Errors: 0, Skipped: 22
   [INFO]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13495: [Test]Fix case demo is more obvious to understand for ReinterpretAsKeyedStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13495:
URL: https://github.com/apache/flink/pull/13495#issuecomment-699753576


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014",
       "triggerID" : "b64812a0cb08a25ee0853c57230ffe12ccc9ceb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111",
       "triggerID" : "d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b64812a0cb08a25ee0853c57230ffe12ccc9ceb3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7014) 
   * d964fbb76ac2b3eda2911eeab5ed6cc2226d8b3c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7111) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org