You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/17 00:10:55 UTC

[GitHub] [nifi] jfrazee commented on a change in pull request #4896: NIFI-7850 - Add missing property for TLS authentication

jfrazee commented on a change in pull request #4896:
URL: https://github.com/apache/nifi/pull/4896#discussion_r595622269



##########
File path: nifi-docker/dockerhub/sh/secure.sh
##########
@@ -60,6 +60,7 @@ prop_replace 'nifi.web.http.host'   ''
 prop_replace 'nifi.web.https.port'  "${NIFI_WEB_HTTPS_PORT:-8443}"
 prop_replace 'nifi.web.https.host'  "${NIFI_WEB_HTTPS_HOST:-$HOSTNAME}"
 prop_replace 'nifi.remote.input.secure' 'true'
+prop_replace 'nifi.cluser.protocol.is.secure' 'true'

Review comment:
       There's a typo in the property name. It's 'cluser' but should be 'cluster'. Since this only applies for clusters I think it'd also make sense to set it to true only if it's a cluster node, so something like this (or an if...then):
   
   ```suggestion
   prop_replace 'nifi.cluser.protocol.is.secure' "${NIFI_CLUSTER_IS_NODE:-false}"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org