You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/08/08 11:06:28 UTC
[PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
hiroyuki-sato opened a new pull request, #47290:
URL: https://github.com/apache/arrow/pull/47290
### Rationale for this change
* SC1090: Can't follow non-constant source. Use a directive to specify location
* SC2086: Double quote to prevent globbing and word splitting
```
In ci/scripts/python_build_emscripten.sh line 26:
source ~/emsdk/emsdk_env.sh
^------------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ci/scripts/python_build_emscripten.sh line 31:
rm -rf ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
rm -rf "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 32:
cp -aL ${source_dir} ${python_build_dir}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
cp -aL "${source_dir}" "${python_build_dir}"
In ci/scripts/python_build_emscripten.sh line 38:
pushd ${python_build_dir}
^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${python_build_dir}"
For more information:
https://www.shellcheck.net/wiki/SC1090 -- ShellCheck can't follow non-const...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### What changes are included in this PR?
* SC1090: disable source file check.
* SC2086: Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47290:
URL: https://github.com/apache/arrow/pull/47290#issuecomment-3167499824
:warning: GitHub issue #47289 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47290:
URL: https://github.com/apache/arrow/pull/47290#issuecomment-3173193123
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8ef974c3a16ad1a9d6f90ad967dc8a434ac2d450.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/47784042391) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47290:
URL: https://github.com/apache/arrow/pull/47290#discussion_r2262656203
##########
.pre-commit-config.yaml:
##########
@@ -348,6 +348,7 @@ repos:
?^ci/scripts/util_enable_core_dumps\.sh$|
?^ci/scripts/util_free_space\.sh$|
?^ci/scripts/util_log\.sh$|
+ ?^python_build_emscripten\.sh$|
Review Comment:
Could you keep this list in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47290:
URL: https://github.com/apache/arrow/pull/47290#issuecomment-3170446984
@github-actions crossbow submit test-conda-python-emscripten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #47290:
URL: https://github.com/apache/arrow/pull/47290#discussion_r2262974520
##########
.pre-commit-config.yaml:
##########
@@ -348,6 +348,7 @@ repos:
?^ci/scripts/util_enable_core_dumps\.sh$|
?^ci/scripts/util_free_space\.sh$|
?^ci/scripts/util_log\.sh$|
+ ?^python_build_emscripten\.sh$|
Review Comment:
Thanks. fixed. I forgot to add `ci/scripts/` prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #47290:
URL: https://github.com/apache/arrow/pull/47290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47289: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_build_emscripten.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47290:
URL: https://github.com/apache/arrow/pull/47290#issuecomment-3170450190
Revision: 0b09f3b7bf0423d6c4259bff87857b1169ae3b10
Submitted crossbow builds: [ursacomputing/crossbow @ actions-360870f623](https://github.com/ursacomputing/crossbow/branches/all?query=actions-360870f623)
|Task|Status|
|----|------|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/16846889704/job/47727679209)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org