You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2014/05/11 15:57:43 UTC

svn commit: r1593792 - /lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java

Author: rmuir
Date: Sun May 11 13:57:43 2014
New Revision: 1593792

URL: http://svn.apache.org/r1593792
Log:
LUCENE-5666: fix testBasic to use dv always

Modified:
    lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java

Modified: lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java?rev=1593792&r1=1593791&r2=1593792&view=diff
==============================================================================
--- lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java (original)
+++ lucene/dev/branches/lucene5666/lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java Sun May 11 13:57:43 2014
@@ -41,6 +41,7 @@ import org.apache.lucene.search.grouping
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.util.BytesRef;
 import org.apache.lucene.util.LuceneTestCase;
+import org.apache.lucene.util.LuceneTestCase.SuppressCodecs;
 import org.apache.lucene.util.TestUtil;
 import org.apache.lucene.util.mutable.MutableValue;
 import org.apache.lucene.util.mutable.MutableValueStr;
@@ -54,6 +55,7 @@ import java.util.*;
 //   - test ties
 //   - test compound sort
 
+@SuppressCodecs({"Lucene40", "Lucene41", "Lucene42"}) // we need missing support... i think?
 public class TestGrouping extends LuceneTestCase {
 
   public void testBasic() throws Exception {
@@ -122,10 +124,6 @@ public class TestGrouping extends Lucene
 
     final Sort groupSort = Sort.RELEVANCE;
 
-    if (random().nextBoolean()) {
-      groupField += "_dv";
-    }
-
     final AbstractFirstPassGroupingCollector<?> c1 = createRandomFirstPassCollector(groupField, groupSort, 10);
     indexSearcher.search(new TermQuery(new Term("content", "random")), c1);
 
@@ -174,8 +172,7 @@ public class TestGrouping extends Lucene
   }
 
   private void addGroupField(Document doc, String groupField, String value) {
-    doc.add(new TextField(groupField, value, Field.Store.YES));
-    doc.add(new SortedDocValuesField(groupField + "_dv", new BytesRef(value)));
+    doc.add(new SortedDocValuesField(groupField, new BytesRef(value)));
   }
 
   private AbstractFirstPassGroupingCollector<?> createRandomFirstPassCollector(String groupField, Sort groupSort, int topDocs) throws IOException {