You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Rita Zhang <no...@github.com> on 2016/01/05 22:08:39 UTC

[jclouds] Add support for AzureBlobStore.getBlobAccess (#898)

At the moment, `AzureBlobStore.getBlobAccess` throws `UnsupportedOperationException`. I have implemented this. Please refer to this [issue](https://github.com/andrewgaul/s3proxy/issues/111) for details. @andrewgaul Please review.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/898

-- Commit Summary --

  * Add support for AzureBlobStore.getBlobAccess

-- File Changes --

    M providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobStore.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/898.patch
https://github.com/jclouds/jclouds/pull/898.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/898

Re: [jclouds] Add support for AzureBlobStore.getBlobAccess (#898)

Posted by Andrew Gaul <no...@github.com>.
Thank you for your contribution @ritazh!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/898#issuecomment-169204007

Re: [jclouds] Add support for AzureBlobStore.getBlobAccess (#898)

Posted by Andrew Gaul <no...@github.com>.
> @@ -368,7 +368,7 @@ public void setContainerAccess(String container, ContainerAccess access) {
>  
>     @Override
>     public BlobAccess getBlobAccess(String container, String key) {
> -      throw new UnsupportedOperationException("unsupported in Azure");
> +      return BlobAccess.PRIVATE;

Could you make a similar change to `RegionScopedSwiftBlobStore.getBlobAccess` and `GlacierBlobStore.getBlobAccess` for consistency?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/898/files#r48900297

Re: [jclouds] Add support for AzureBlobStore.getBlobAccess (#898)

Posted by Rita Zhang <no...@github.com>.
> @@ -368,7 +368,7 @@ public void setContainerAccess(String container, ContainerAccess access) {
>  
>     @Override
>     public BlobAccess getBlobAccess(String container, String key) {
> -      throw new UnsupportedOperationException("unsupported in Azure");
> +      return BlobAccess.PRIVATE;

Done for `AzureBlobStore.getBlobAccess` and `RegionScopedSwiftBlobStore.getBlobAccess`. Will fix `GlacierBlobStore.getBlobAccess` [here](https://github.com/jclouds/jclouds-labs-aws/blob/master/glacier/src/main/java/org/jclouds/glacier/blobstore/GlacierBlobStore.java)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/898/files#r48911868

Re: [jclouds] Add support for AzureBlobStore.getBlobAccess (#898)

Posted by Andrew Gaul <no...@github.com>.
Could you update the commit message explaining the motivation for this change?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/898#issuecomment-169143085