You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (Created) (JIRA)" <ji...@apache.org> on 2011/11/23 21:29:42 UTC

[jira] [Created] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Setting no_drop on a table should cascade to child partitions
-------------------------------------------------------------

                 Key: HIVE-2605
                 URL: https://issues.apache.org/jira/browse/HIVE-2605
             Project: Hive
          Issue Type: Improvement
            Reporter: Namit Jain
            Assignee: Namit Jain


When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159104#comment-13159104 ] 

Hudson commented on HIVE-2605:
------------------------------

Integrated in Hive-trunk-h0.21 #1110 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1110/])
    HIVE-2605: Setting no_drop on a table should cascade to child partitions (namit via He Yongqiang)

heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207701
Files : 
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ProtectMode.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
* /hive/trunk/ql/src/test/queries/clientnegative/protectmode_tbl6.q
* /hive/trunk/ql/src/test/queries/clientnegative/protectmode_tbl7.q
* /hive/trunk/ql/src/test/queries/clientnegative/protectmode_tbl8.q
* /hive/trunk/ql/src/test/queries/clientpositive/protectmode2.q
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl6.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl7.q.out
* /hive/trunk/ql/src/test/results/clientnegative/protectmode_tbl8.q.out
* /hive/trunk/ql/src/test/results/clientpositive/protectmode2.q.out

                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2605:
------------------------------

    Attachment: HIVE-2605.D525.1.patch

njain requested code review of "HIVE-2605 [jira] Setting no_drop on a table should cascade to child partitions".
Reviewers: JIRA

  HIVE-2605

  When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D525

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/ProtectMode.java
  ql/src/test/results/clientnegative/protectmode_tbl7.q.out
  ql/src/test/results/clientnegative/protectmode_tbl8.q.out
  ql/src/test/results/clientnegative/protectmode_tbl6.q.out
  ql/src/test/results/clientpositive/protectmode2.q.out
  ql/src/test/queries/clientnegative/protectmode_tbl6.q
  ql/src/test/queries/clientnegative/protectmode_tbl7.q
  ql/src/test/queries/clientnegative/protectmode_tbl8.q
  ql/src/test/queries/clientpositive/protectmode2.q
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java
  ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/1155/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "He Yongqiang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156376#comment-13156376 ] 

He Yongqiang commented on HIVE-2605:
------------------------------------

running tests.
                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "He Yongqiang (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang resolved HIVE-2605.
--------------------------------

    Resolution: Fixed

committed, thanks namit!
                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156295#comment-13156295 ] 

Phabricator commented on HIVE-2605:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-2605 [jira] Setting no_drop on a table should cascade to child partitions".

  I can't commit changes so I'll leave accepting to someone who has the necessary permissions.

  Looks good to me.  Could you comment in the code and/or update in the wiki
  https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-AlterTable%2FPartitionProtections
  a description of what this does, in particular, it looks like this won't have an effect if it's set on a partition (which makes sense).

REVISION DETAIL
  https://reviews.facebook.net/D525

                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Namit Jain (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156352#comment-13156352 ] 

Namit Jain commented on HIVE-2605:
----------------------------------

The semantics of

alter table <T> enable no_drop cascase;

is as follows.

If a table is marked as no_drop cascade, neither the table nor any of it's partitions can be dropped.
                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156342#comment-13156342 ] 

Phabricator commented on HIVE-2605:
-----------------------------------

njain has commented on the revision "HIVE-2605 [jira] Setting no_drop on a table should cascade to child partitions".

  I will add comments the wiki.

  The existing partitions will be affected.
  I mean, if I set this on a table, the existing partitions also cannot be dropped.

REVISION DETAIL
  https://reviews.facebook.net/D525

                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2605) Setting no_drop on a table should cascade to child partitions

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156306#comment-13156306 ] 

Phabricator commented on HIVE-2605:
-----------------------------------

heyongqiang has commented on the revision "HIVE-2605 [jira] Setting no_drop on a table should cascade to child partitions".

  How about existing partitions?

REVISION DETAIL
  https://reviews.facebook.net/D525

                
> Setting no_drop on a table should cascade to child partitions
> -------------------------------------------------------------
>
>                 Key: HIVE-2605
>                 URL: https://issues.apache.org/jira/browse/HIVE-2605
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: HIVE-2605.D525.1.patch
>
>
> When NO_DROP is set on a table, it does not cascade to the partitions of the table.  There should be an option to do so.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira