You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2023/03/02 16:22:04 UTC
[GitHub] [kafka] chia7712 opened a new pull request, #13327: MINOR: tweak the doc of "num.network.threads"
chia7712 opened a new pull request, #13327:
URL: https://github.com/apache/kafka/pull/13327
send readers a reminder: the total number of network threads is `listeners * num.network.threads`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a diff in pull request #13327: MINOR: tweak the doc of "num.network.threads"
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #13327:
URL: https://github.com/apache/kafka/pull/13327#discussion_r1124201822
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -678,7 +678,7 @@ object KafkaConfig {
"start from " + MaxReservedBrokerIdProp + " + 1."
val MessageMaxBytesDoc = TopicConfig.MAX_MESSAGE_BYTES_DOC +
s"This can be set per topic with the topic level <code>${TopicConfig.MAX_MESSAGE_BYTES_CONFIG}</code> config."
- val NumNetworkThreadsDoc = "The number of threads that the server uses for receiving requests from the network and sending responses to the network"
+ val NumNetworkThreadsDoc = s"The number of threads that the server uses for receiving requests from the network and sending responses to the network. Noted: each listener (except for control plane listener) creates its own thread pool."
Review Comment:
will copy that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #13327: MINOR: tweak the doc of "num.network.threads"
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #13327:
URL: https://github.com/apache/kafka/pull/13327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #13327: MINOR: tweak the doc of "num.network.threads"
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13327:
URL: https://github.com/apache/kafka/pull/13327#discussion_r1124118829
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -678,7 +678,7 @@ object KafkaConfig {
"start from " + MaxReservedBrokerIdProp + " + 1."
val MessageMaxBytesDoc = TopicConfig.MAX_MESSAGE_BYTES_DOC +
s"This can be set per topic with the topic level <code>${TopicConfig.MAX_MESSAGE_BYTES_CONFIG}</code> config."
- val NumNetworkThreadsDoc = "The number of threads that the server uses for receiving requests from the network and sending responses to the network"
+ val NumNetworkThreadsDoc = s"The number of threads that the server uses for receiving requests from the network and sending responses to the network. Noted: each listener (except for control plane listener) creates its own thread pool."
Review Comment:
nit: I don't think we have this term: `control plane listener` in the doc. Maybe using controller listener?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org