[GitHub] [skywalking] adriancole commented on a change in pull request #3208: zipkin receive issue fix for Not in Gzip format and span.kind is null

[GitBox <gi...@apache.org>]

adriancole commented on a change in pull request #3208: zipkin receive issue fix for Not in Gzip format and span.kind is null
URL: https://github.com/apache/skywalking/pull/3208#discussion_r310068170
 
 

 ##########
 File path: oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/handler/SpanProcessor.java
 ##########
 @@ -69,7 +69,7 @@ void convert(ZipkinReceiverConfig config, SpanBytesDecoder decoder, HttpServletR
     private InputStream getInputStream(HttpServletRequest request) throws IOException {
         InputStream requestInStream;
 
-        String headEncoding = request.getHeader("accept-encoding");
+        String headEncoding = request.getHeader("Content-Encoding");
 
 Review comment:
   content-encoding is for the incoming payload. there's no format defined for the response sent back to the client as we just send status 202. iotw, accept-encoding isn't that relevant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services